chore: clear SonarCloud code smells (78 → 0)#42
Merged
Conversation
All open issues were CODE_SMELL (0 bugs, 0 vulns; gate already green). Fix
the genuine ones and suppress the rules that conflict with mandatory FFM
idiom or an enforced project convention:
Fixed:
- S6213 (28) rename variables matching restricted identifiers
- S5838 (6) use AssertJ hasSize/hasSizeLessThan
- S5853 (3) chain assertions on the same actual (left the side-effecting
InputStream.read() triple alone — chaining would change reads)
- S1066 (1) merge nested if in ZstdInputStream.produce() (behavior-identical)
- S7467 (1) unnamed pattern for an unused binding
Suppressed (with justification):
- S7474 (34) pom-level ignore: the rule wants {@link}/HTML javadoc, which the
project forbids (mandates `///` Markdown + [Class#method] refs,
checkstyle-enforced)
- S112 (3) @SuppressWarnings on the invokeExact wrapper interfaces
- S1181 (1) catching Throwable is mandatory: MethodHandle.invokeExact throws it
- S3776 (1) produce() complexity is inherent to the decode/EOF loop and tested
No production behavior change. validate + test green.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All 78 open SonarCloud issues were CODE_SMELL (0 bugs, 0 vulnerabilities; quality gate already green). This fixes the genuine ones and suppresses the rules that conflict with mandatory FFM idiom or an enforced project convention.
Fixed
hasSize/hasSizeLessThanInputStream.read()triple alone — chaining would collapse three distinct reads)ifinZstdInputStream.produce()(behavior-identical:if(a){if(b)}→if(a&&b))Suppressed (with justification)
{@link}/HTML javadoc, which the project forbids (mandates///Markdown +[Class#method]refs, checkstyle-enforced).@SuppressWarningson theinvokeExactwrapper interfaces (declaredthrows Throwable)Throwableis mandatory:MethodHandle.invokeExactthrows itproduce()complexity is inherent to the decode/EOF loop and is testedNo production behavior change.
validate+testgreen. Reviewed (produce() equivalence confirmed; suppressions verified 1:1 against reported issues).🤖 Generated with Claude Code